Skip to content

Conversation

@Anmol202005
Copy link
Collaborator

Part of: #41
Updated upperEllTest to extend AbstractRecipeTestSupport.

@Anmol202005
Copy link
Collaborator Author

@rdiachenko
not adding // violation comments now, i guess will be good to add after the preprocessing recipe is done.
although i am fine if u suggest to add now.

@rdiachenko rdiachenko self-assigned this Jul 21, 2025
@rdiachenko
Copy link
Member

@rdiachenko not adding // violation comments now, i guess will be good to add after the preprocessing recipe is done. although i am fine if u suggest to add now.

Yes, let's do it as a separate step. We need also check related Checkstyle test code to enforce // violation comments, so when there is violation but missed comment, we should fail. In the postprocessing step when we remove // violation it probably makes sense to run Checkstyle again on the output processed file to test Checkstyle doesn't give violations. This way we'll have end-to-end testing

Copy link
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko merged commit a2d69a9 into checkstyle:main Jul 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants